Updating examples to use tracer_source #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 38 38
Lines 1839 1839
Branches 217 217
=======================================
Hits 1560 1560
Misses 214 214
Partials 65 65Continue to review full report at Codecov.
|
lzchen
reviewed
Jan 13, 2020
| from opentelemetry.ext.dbapi import trace_integration | ||
|
|
||
|
|
||
| # Ex: mysql.connector | ||
| trace_integration(tracer(), mysql.connector, "connect", "mysql") | ||
| trace_integration(tracer_source(), mysql.connector, "connect", "mysql") |
There was a problem hiding this comment.
Doesn't trace_integration take in parameter type tracer?
There was a problem hiding this comment.
Good catch, it looks like the dbapi integration needs to be updated like the others in #301.
There was a problem hiding this comment.
I believe @hectorhdzg is addressing this in [#298]
c24t
approved these changes
Jan 14, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: add examples folder to lerna * fix: add private to package.json files in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few examples that hadn't been updated to use
tracer_source()instead of `tracer(), updating them here.Signed-off-by: Alex Boten aboten@lightstep.com