Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProxyLoggerProvider, ProxyLogger and associated tests #3575

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

garry-cairns
Copy link
Contributor

@garry-cairns garry-cairns commented Dec 9, 2023

Description

Resolves issue 3060 by adding ProxyLoggerProvider, ProxyLogger and associated tests.

Fixes #3060

Type of change

  • [] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test cases added and passing with tox -e opentelemetry-api

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@garry-cairns garry-cairns requested a review from a team December 9, 2023 16:27
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some comments

CHANGELOG.md Outdated Show resolved Hide resolved
opentelemetry-api/src/opentelemetry/_logs/__init__.py Outdated Show resolved Hide resolved
@srikanthccv srikanthccv changed the title 3060 adds ProxyLoggerProvider, ProxyLogger and associated tests Add ProxyLoggerProvider, ProxyLogger and associated tests Dec 31, 2023
@garry-cairns
Copy link
Contributor Author

@srikanthccv Do you need anything more from me here? I'm really keen to do anything we can to progress logs to stable as I'm looking to get them into production where I work this year.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about changelog entry, otherwise looks good to me.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Please take a look at #3361 if you are interested in helping make logs SDK stable.

auto-merge was automatically disabled February 8, 2024 00:49

Pull Request is not mergeable

@garry-cairns garry-cairns deleted the feature/3060 branch February 8, 2024 10:29
@garry-cairns garry-cairns restored the feature/3060 branch February 8, 2024 10:34
@garry-cairns
Copy link
Contributor Author

@ocelotl Sorry I misread what had happened here and deleted my branch, which closed the PR. Reopening so this can be merged properly.

@garry-cairns garry-cairns reopened this Feb 8, 2024
@ocelotl ocelotl enabled auto-merge (squash) February 9, 2024 01:25
auto-merge was automatically disabled February 9, 2024 01:31

Pull Request is not mergeable

@ocelotl ocelotl merged commit 3500f5c into open-telemetry:main Feb 9, 2024
270 checks passed
@garry-cairns garry-cairns deleted the feature/3060 branch February 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proxies for logging api classes
3 participants