Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: ObservedTimestamp field is missing in console exporter output #3564

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Logs: ObservedTimestamp field is missing in console exporter output #3564

merged 7 commits into from
Feb 8, 2024

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Dec 3, 2023

Description

Add ObservedTimestamp field

Fixes #3550

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@pegasas pegasas requested a review from a team December 3, 2023 05:28
@srikanthccv
Copy link
Member

Please fix the tests and add CHANGELOG entry

@pegasas
Copy link
Contributor Author

pegasas commented Jan 6, 2024

Please fix the tests and add CHANGELOG entry

Done these 2 pending items.
Thanks for reviewing!

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

CHANGELOG.md Outdated Show resolved Hide resolved
@ocelotl ocelotl enabled auto-merge (squash) February 8, 2024 00:25
auto-merge was automatically disabled February 8, 2024 00:27

Pull Request is not mergeable

@ocelotl ocelotl merged commit d03a622 into open-telemetry:main Feb 8, 2024
270 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs: ObservedTimestamp field is missing in console exporter output
3 participants