-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor InMemoryMetricExporter and add tests #3519
Refactor InMemoryMetricExporter and add tests #3519
Conversation
Don't think this pull needs the changelog update, but happy to add it if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion.
|
||
This class can be used for testing purposes. It stores the exported metrics | ||
in a dictionary in memory, indexed by an auto-incrementing counter that can | ||
be retrieved using the `metrics` attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be retrieved using the `metrics` attribute. | |
be retrieved using the `_counter` attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did intend to highlight the metrics
attribute, you could rephrase the text to something like:
This class is designed for testing purposes. It maintains exported metrics in the
metrics
dictionary attribute.
I don't think we need to add |
I agree, @nstawski, I'm closing this PR because of the reasons above, please let me know if you disagree 👍 |
Description
This is a pull to separate the refactor of InMemoryMetricExporter from its usage in the pull#3486
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: