Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the body type in the log #3343

Merged
merged 11 commits into from
Jul 12, 2023
Merged

Update the body type in the log #3343

merged 11 commits into from
Jul 12, 2023

Conversation

GanymedeNil
Copy link
Contributor

@GanymedeNil GanymedeNil commented Jun 12, 2023

Description

According to the definition of the Body field type in the OTel 1.22.0 Logs Data Model article, the Body field should be of type 'any' and should not use the str method to directly translate the msg. This is because str only converts non-text types into a human-readable form, rather than a standard format, which leads to the need for additional operations when collected through a log collector.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@GanymedeNil GanymedeNil requested a review from a team June 12, 2023 15:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@shalevr
Copy link
Member

shalevr commented Jun 15, 2023

Can you please add a test to be clear about which cases you want to correct

@GanymedeNil
Copy link
Contributor Author

Can you please add a test to be clear about which cases you want to correct

All right, I will include test cases.

@ocelotl ocelotl merged commit 7bb21f5 into open-telemetry:main Jul 12, 2023
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants