Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding support for setting OTLP exporter protocol by env vars #2892

Closed
wants to merge 1 commit into from

Conversation

ronyis
Copy link
Contributor

@ronyis ronyis commented Aug 28, 2022

Description

Fixes #2586

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ronyis ronyis requested a review from a team August 28, 2022 13:15
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@ronyis ronyis changed the title Adding support for setting OTLP exporter protocol by env vars [WIP] Adding support for setting OTLP exporter protocol by env vars Aug 28, 2022
@ronyis ronyis marked this pull request as draft August 28, 2022 13:17
@ronyis ronyis closed this Aug 28, 2022
@ronyis ronyis deleted the otlp-protocol-env-vars branch August 28, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting any value to OTEL_EXPORTER_OTLP_PROTOCOL has no effect.
1 participant