-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variadic arguments to metric exporter/reader interfaces #2654
Conversation
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
What about adding |
Not sure if that is necessary, the idea is that we need I guess in the future we could have that constructor call and in theory every method could be in this situation, so the "right" policy would be to add |
Is that what the original issue is about? The original issue says add args and kwargs to "user implementable interfaces". The constructors should be part of that no?
I think this is what we want right? We want to have the flexibility to change the signature of every user exposed interface, including methods. |
If that is the case we should mark the constructor with |
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/export/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/measurement_consumer.py
Outdated
Show resolved
Hide resolved
This reverts commit 7eb6134.
21a8ae1
to
6bf8feb
Compare
Fixes #2650