Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zero or more callbacks #2602

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Add support for zero or more callbacks #2602

merged 5 commits into from
Apr 14, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 13, 2022

Fixes #2601

@ocelotl ocelotl self-assigned this Apr 13, 2022
@ocelotl ocelotl requested a review from a team April 13, 2022 23:17
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2022
codeboten
codeboten reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@ocelotl ocelotl removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2022
@ocelotl ocelotl requested a review from codeboten April 13, 2022 23:33
@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 13, 2022

Please add a changelog entry

Done ✌️

ocelotl and others added 2 commits April 14, 2022 12:15
@ocelotl @lzchen
Update opentelemetry-api/src/opentelemetry/_metrics/__init__.py
539d894 
Co-authored-by: Leighton Chen <lechen@microsoft.com>
@ocelotl @lzchen
Update opentelemetry-api/src/opentelemetry/_metrics/__init__.py
47680e6 
Co-authored-by: Leighton Chen <lechen@microsoft.com>
@ocelotl ocelotl merged commit ba97fe9 into open-telemetry:main Apr 14, 2022
@lzchen lzchen mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for zero or more callbacks
3 participants
@ocelotl @codeboten @lzchen