-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OTLPHandler -> LoggingHandler #2528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging library from python stdlib is the most widely used one but there are also some other third party libraries ex structlog. I am thinking if we want to make it explicit in the name that this handler targeting the logging
module?
Any suggestions on the name? We could either rename or maybe stick with generic |
No. I think if there is a need for one in future we can introduce new handler. I think this is also what java does - they have different appenders for different libs. |
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be renamed to Handler
instead. Otherwise this makes me ask the question why isn't Otel
a prefix for every component in the library.
This is a good point ⬆️ |
@ocelotl @codeboten @srikanthccv |
That would still be redundant, since the symbol would be imported from I have approved in order not to block here, I'm pretty sure we have not followed this logic in other parts of the project also. |
I'm ok with the idea LoggingHandler as it implies the connection to the logging library. |
Fixes #2506