Rename base test assertion methods for consistency #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
aabmass and
NathanielRN
and removed request for
a team
11 tasks
12 tasks
owais
force-pushed
the
update-base-test
branch
2 times, most recently
from
6321479
to
3ed70c5
Compare
aabmass
approved these changes
Aug 30, 2021
owais
force-pushed
the
update-base-test
branch
from
3ed70c5
to
53c5b48
Compare
codeboten
approved these changes
Aug 30, 2021
owais
force-pushed
the
update-base-test
branch
from
53c5b48
to
a63dec4
Compare
codeboten
reviewed
Aug 30, 2021
| @@ -44,11 +46,11 @@ def tearDownClass(cls): | |||
| def setUp(self): | |||
| self.memory_exporter.clear() | |||
|
|
|||
| def check_span_instrumentation_info(self, span, module): | |||
| def assertSpanInstrumentationInfo(self, span, module): | |||
There was a problem hiding this comment.
Mentioned this in the contrib repo PR, but I would prefer the name assertSpanHasInstrumentationInfo
owais
force-pushed
the
update-base-test
branch
from
a63dec4
to
bdd96bf
Compare
owais
force-pushed
the
update-base-test
branch
from
bdd96bf
to
9957a51
Compare
ocelotl
requested changes
Aug 30, 2021
| @@ -44,11 +46,11 @@ def tearDownClass(cls): | |||
| def setUp(self): | |||
| self.memory_exporter.clear() | |||
|
|
|||
| def check_span_instrumentation_info(self, span, module): | |||
| def assertSpanHasInstrumentationInfo(self, span, module): | |||
There was a problem hiding this comment.
Hm, not trying to be nitpicky but this name is misleading. It is not checking that the span has instrumentation info but that the span instrumentation info is the same as the one in the module.
There was a problem hiding this comment.
Maybe assertEqualSpanModuleInstrumentationInfo? 🤷
ocelotl
approved these changes
Aug 30, 2021
|
I'm merging before other approvers want more renames. 😂 |
codeboten
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update base test class to have more consistent assertion methods with rest of Python ecosystem.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: