Do not count skipped baggage entries #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
requested review from
a team,
aabmass and
srikanthccv
and removed request for
a team
srikanthccv
reviewed
Aug 30, 2021
lzchen
reviewed
Aug 30, 2021
| @@ -68,6 +65,9 @@ def extract( | |||
| urllib.parse.unquote(value).strip(), | |||
| context=context, | |||
| ) | |||
| total_baggage_entries -= 1 | |||
There was a problem hiding this comment.
Curious as to why we are counting backwards as opposed to simply just counting to _MAX_PAIRS?
There was a problem hiding this comment.
🤷 It was implemented like that, so I kept the implementation.
owais
approved these changes
Aug 31, 2021
lzchen
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2071