Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentelemetry-instrumentation to contrib #1797

Merged
merged 8 commits into from
Apr 26, 2021
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Please describe the tests that you ran to verify your changes. Provide instructi

Answer the following question based on these examples of changes that would require a Contrib Repo Change:
- [The OTel specification](https://github.com/open-telemetry/opentelemetry-specification) has changed which prompted this PR to update the method interfaces of `opentelemetry-api/` or `opentelemetry-sdk/`
- The method interfaces of `opentelemetry-instrumentation/` have changed
- The method interfaces of `test/util` have changed
- Scripts in `scripts/` that were copied over to the Contrib repo have changed
- Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
# Otherwise, set variable to the commit of your branch on
# opentelemetry-python-contrib which is compatible with these Core repo
# changes.
CONTRIB_REPO_SHA: 793ddb4ed638231f387eef2e11207ffb18c6682a
CONTRIB_REPO_SHA: bcd337f74db582684e29fd5e0a9a2de591566c9b

jobs:
build:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.1.0...HEAD)

### Removed
- Moved `opentelemetry-instrumentation` to contrib repository
([#1797](https://github.com/open-telemetry/opentelemetry-python/pull/1797))

## [1.1.0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.1.0) - 2021-04-20

### Added
Expand Down
3 changes: 1 addition & 2 deletions docs-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ sphinx-autodoc-typehints
./opentelemetry-api
./opentelemetry-semantic-conventions
./opentelemetry-sdk
./opentelemetry-instrumentation

# Required by ext packages
# Required by instrumentation and exporter packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these dependencies after instrumentation is moved away?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are needed for some of the examples.

asgiref~=3.0
asyncpg>=0.12.0
ddtrace>=0.34.0
Expand Down
7 changes: 1 addition & 6 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@

settings.configure()


source_dirs = [
os.path.abspath("../opentelemetry-instrumentation/src/"),
]

exp = "../exporter"
exp_dirs = [
os.path.abspath("/".join(["../exporter", f, "src"]))
Expand All @@ -42,7 +37,7 @@
if isdir(join(shim, f))
]

sys.path[:0] = source_dirs + exp_dirs + shim_dirs
sys.path[:0] = exp_dirs + shim_dirs

# -- Project information -----------------------------------------------------

Expand Down
3 changes: 0 additions & 3 deletions eachdist.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,10 @@ ignore=
sortfirst=
opentelemetry-api
opentelemetry-sdk
opentelemetry-instrumentation
opentelemetry-proto
opentelemetry-distro
tests/util
instrumentation/*
exporter/*
ext/*

[lintroots]
extraroots=examples/*,scripts/
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-distro/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ zip_safe = False
include_package_data = True
install_requires =
opentelemetry-api == 1.2.0.dev0
opentelemetry-instrumentation == 0.21.dev0
opentelemetry-sdk == 1.2.0.dev0

[options.packages.find]
Expand Down
3 changes: 3 additions & 0 deletions opentelemetry-distro/src/opentelemetry/distro/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ def _initialize_components():


class Configurator(BaseConfigurator):

# pylint: disable=no-self-use
def _configure(self, **kwargs):
_initialize_components()

Expand All @@ -157,5 +159,6 @@ class OpenTelemetryDistro(BaseDistro):
configuration out of the box.
"""

# pylint: disable=no-self-use
def _configure(self, **kwargs):
os.environ.setdefault(OTEL_TRACES_EXPORTER, "otlp_proto_grpc_span")
7 changes: 0 additions & 7 deletions opentelemetry-instrumentation/MANIFEST.in

This file was deleted.

112 changes: 0 additions & 112 deletions opentelemetry-instrumentation/README.rst

This file was deleted.

56 changes: 0 additions & 56 deletions opentelemetry-instrumentation/setup.cfg

This file was deleted.

29 changes: 0 additions & 29 deletions opentelemetry-instrumentation/setup.py

This file was deleted.

Loading