Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OTEL_TRACE_SAMPLER and OTEL_TRACE_SAMPLER_ARG env variables #1496

Merged
merged 40 commits into from
Jan 19, 2021
Merged

Add support for OTEL_TRACE_SAMPLER and OTEL_TRACE_SAMPLER_ARG env variables #1496

merged 40 commits into from
Jan 19, 2021

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Dec 19, 2020 •
edited
Loading

Description

Fixes #1476

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • tox -e test-core-sdk

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@srikanthccv srikanthccv requested review from a team, owais and codeboten and removed request for a team December 19, 2020 09:26
@codeboten codeboten requested a review from lzchen January 7, 2021 16:15
@srikanthccv srikanthccv mentioned this pull request Jan 13, 2021
Closed
codeboten
codeboten approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lzchen lzchen merged commit 9a1f594 into open-telemetry:master Jan 19, 2021
@srikanthccv srikanthccv deleted the trace-sampler-env branch September 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OTEL_TRACE_SAMPLER + OTEL_TRACE_SAMPLER_ARG env variable
4 participants
@srikanthccv @owais @codeboten @lzchen