Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf via gRPC exporting support for Jaeger #1471
Add protobuf via gRPC exporting support for Jaeger #1471
Changes from 33 commits
0e9976c
b6b25bd
f431dbe
dc9b59a
4da0209
e8673fa
c1a5e61
e34f5d9
84533a6
47570ff
3dc0ede
ff506a8
cfef392
b435a12
58497bf
07771eb
ec310ac
8e98f5a
b091816
cc9cf7f
a732ff3
c1907f4
b730cd2
a4f655f
76a9a42
a7c78fe
b78a09b
5e51115
647a211
1aba1f9
44635a9
54aace1
cf1b278
7a13b69
504b676
a7b0f1c
add23d2
9070d73
68c477c
6aaf2a0
fab1ed1
87f6274
cf8c72c
f105915
206622f
070b28f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this isn't required for all exporter configurations, should this be an extras_require?
I personally don't care about bloating package dependencies and including unneeded ones, but I've found that to be a prickly subject for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is needed as we have import for from grpc and typehints in certain places.