Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Instrumentation and Exporter Code From Core Repo #1258

Merged
merged 4 commits into from
Nov 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ exclude =
docs/examples/opentelemetry-example-app/build/*
opentelemetry-proto/build/*
opentelemetry-proto/src/opentelemetry/proto/
opentelemetry-python-contrib/
20 changes: 18 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches-ignore:
- 'release/*'
pull_request:
env:
CONTRIB_REPO_SHA: 5c9e043d6921550d82668788e3758a733fb11cb8

jobs:
build:
Expand Down Expand Up @@ -41,7 +43,14 @@ jobs:
python-version: py35
package: instrumentation
steps:
- uses: actions/checkout@v2
- name: Checkout Core Repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v2
- name: Checkout Contrib Repo @ SHA - ${{ env.CONTRIB_REPO_SHA }}
uses: actions/checkout@v2
with:
repository: open-telemetry/opentelemetry-python-contrib
ref: ${{ env.CONTRIB_REPO_SHA }}
path: opentelemetry-python-contrib
- name: Set up Python ${{ env[matrix.python-version] }}
uses: actions/setup-python@v2
with:
Expand All @@ -64,7 +73,14 @@ jobs:
name: ${{ matrix.tox-environment }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout Core Repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v2
- name: Checkout Contrib Repo @ SHA - ${{ env.CONTRIB_REPO_SHA }}
uses: actions/checkout@v2
with:
repository: open-telemetry/opentelemetry-python-contrib
ref: ${{ env.CONTRIB_REPO_SHA }}
path: opentelemetry-python-contrib
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ lib64
__pycache__
venv*/
.venv*/
opentelemetry-python-contrib/

# Installer logs
pip-log.txt
Expand Down
2 changes: 1 addition & 1 deletion .isort.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ line_length=79
; docs: https://github.com/timothycrosley/isort#multi-line-output-modes
multi_line_output=3
skip=target
skip_glob=**/gen/*,.venv*/*,venv*/*,**/proto/*
skip_glob=**/gen/*,.venv*/*,venv*/*,**/proto/*,opentelemetry-python-contrib/*
known_first_party=opentelemetry,opentelemetry_example_app
known_third_party=psutil,pytest,redis,redis_opentracing
2 changes: 1 addition & 1 deletion docs/examples/django/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,4 @@ References

* `Django <https://djangoproject.com/>`_
* `OpenTelemetry Project <https://opentelemetry.io/>`_
* `OpenTelemetry Django extension <https://github.com/open-telemetry/opentelemetry-python/tree/master/instrumentation/opentelemetry-instrumentation-django>`_
* `OpenTelemetry Django extension <https://github.com/open-telemetry/opentelemetry-python-contib/tree/master/instrumentation/opentelemetry-instrumentation-django>`_
1 change: 0 additions & 1 deletion docs/examples/django/pages/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from django.http import HttpResponse

from opentelemetry import trace
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import (
Expand Down
4 changes: 2 additions & 2 deletions docs/examples/opentelemetry-example-app/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ include_package_data = True
install_requires =
opentelemetry-api == 0.16.dev0
opentelemetry-sdk == 0.16.dev0
opentelemetry-instrumentation-requests == 0.16.dev0
opentelemetry-instrumentation-flask == 0.16.dev0
opentelemetry-instrumentation-requests == 0.15.b0
opentelemetry-instrumentation-flask == 0.15.b0
NathanielRN marked this conversation as resolved.
Show resolved Hide resolved
flask
requests
protobuf>=3.13.0
Expand Down
7 changes: 0 additions & 7 deletions docs/exporter/datadog/datadog.rst

This file was deleted.

2 changes: 1 addition & 1 deletion docs/getting-started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ The above is a great example, but it's very manual. Within the telemetry space,
* Database calls

To help instrument common scenarios, opentelemetry also has the concept of "instrumentations": packages that are designed to interface
with a specific framework or library, such as Flask and psycopg2. A list of the currently curated extension packages can be found :scm_web:`here <instrumentation/>`.
with a specific framework or library, such as Flask and psycopg2. A list of the currently curated extension packages can be found `at the Contrib repo <https://github.com/open-telemetry/opentelemetry-python-contrib/tree/master/instrumentation>`_.

We will now instrument a basic Flask application that uses the requests library to send HTTP requests. First, install the instrumentation packages themselves:

Expand Down
6 changes: 4 additions & 2 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ In addition, there are several extension packages which can be installed separat
pip install opentelemetry-instrumentation-{instrumentation}

These are for exporter and instrumentation packages respectively.
The packages can be found in :scm_web:`instrumentation <instrumentation/>` and :scm_web:`exporter <exporter/>` directory of the repository.
Some packages can be found in :scm_web:`instrumentation <instrumentation/>` and :scm_web:`exporter <exporter/>`
directory of the repository. The remaining packages can be found at the
`Contrib repo instrumentation <https://github.com/open-telemetry/opentelemetry-python-contrib/tree/master/instrumentation>`_
and `Contrib repo exporter <https://github.com/open-telemetry/opentelemetry-python-contrib/tree/master/exporter>`_ directories.

Extensions
----------
Expand All @@ -53,7 +56,6 @@ install <https://pip.pypa.io/en/stable/reference/pip_install/#editable-installs>
cd opentelemetry-python
pip install -e ./opentelemetry-api
pip install -e ./opentelemetry-sdk
pip install -e ./instrumentation/opentelemetry-instrumentation-{instrumentation}


.. toctree::
Expand Down
7 changes: 0 additions & 7 deletions docs/instrumentation/aiohttp_client/aiohttp_client.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/aiopg/aiopg.rst

This file was deleted.

9 changes: 0 additions & 9 deletions docs/instrumentation/asgi/asgi.rst

This file was deleted.

10 changes: 0 additions & 10 deletions docs/instrumentation/asyncpg/asyncpg.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/boto/boto.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/botocore/botocore.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/celery/celery.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/dbapi/dbapi.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/django/django.rst

This file was deleted.

9 changes: 0 additions & 9 deletions docs/instrumentation/fastapi/fastapi.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/flask/flask.rst

This file was deleted.

10 changes: 0 additions & 10 deletions docs/instrumentation/grpc/grpc.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/jinja2/jinja2.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/mysql/mysql.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/psycopg2/psycopg2.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/pymemcache/pymemcache.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/pymongo/pymongo.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/pymysql/pymysql.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/pyramid/pyramid.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/redis/redis.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/requests/requests.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/sqlalchemy/sqlalchemy.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/sqlite3/sqlite3.rst

This file was deleted.

9 changes: 0 additions & 9 deletions docs/instrumentation/starlette/starlette.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/system_metrics/system_metrics.rst

This file was deleted.

7 changes: 0 additions & 7 deletions docs/instrumentation/wsgi/wsgi.rst

This file was deleted.

3 changes: 3 additions & 0 deletions eachdist.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# These will be sorted first in that order.
# All packages that are depended upon by others should be listed here.
[DEFAULT]
ignore=
opentelemetry-python-contrib

sortfirst=
opentelemetry-api
opentelemetry-sdk
Expand Down
31 changes: 0 additions & 31 deletions exporter/opentelemetry-exporter-datadog/CHANGELOG.md

This file was deleted.

Loading