Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OTEL_LOG_LEVEL env var #1069

Closed
wants to merge 2 commits into from
Closed

Add support for OTEL_LOG_LEVEL env var #1069

wants to merge 2 commits into from

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Sep 3, 2020

Description

Adds support for configuring the SDK log level using the OTEL_LOG_LEVEL environment variable.

Fixes #1059

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 3, 2020
@ffe4 ffe4 mentioned this pull request Sep 10, 2020
Closed
@codeboten codeboten added release:after-ga To be resolved after GA release and removed release:required-for-ga To be resolved before GA release labels Oct 15, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
feat: add OTEL_SAMPLING_PROBABILITY env var (open-telemetry#1069)
0f0c08a 
Allows user to configure tracer's sampling probability via an env var.

Uses parentOrElse sampler with a probability sampler delegate when setting OTEL_SAMPLING_PROBABILITY

Defaults to AlwaysOnSampler when unset or set to 1.

Signed-off-by: Naseem <naseem@transit.app>
@lzchen
Copy link
Contributor

lzchen commented Nov 12, 2020

@ffe4
Any updates on this?

@ffe4
Copy link
Contributor Author

ffe4 commented Nov 13, 2020 •
edited
Loading

@lzchen there wasn't much discussion in the specs issue for clarifying the allowed env var values open-telemetry/opentelemetry-specification#920 and it has been marked for after GA. The issue does not have the allowed-for-ga label but the env var is still on the matrix, so I'm not entirely sure what that means for this PR.

@lzchen
Copy link
Contributor

lzchen commented Nov 13, 2020

@ffe4
Makes sense. Maybe post a comment to put this topic on peoples' radars again? I would also outline the fact that it is part of the feature matrix so it must be prioritized.

@ffe4
Copy link
Contributor Author

ffe4 commented Nov 14, 2020

@lzchen
I've posted a comment to the issue. I also noticed that we removed the top level __init__.py in #1205, so the content of this PR is now kind of irrelevant anyway.

I'll have a look once the spec issue is resolved, but it might make sense to just close this PR for now and post updates to the issue instead.

@lzchen
Copy link
Contributor

lzchen commented Nov 16, 2020

Closing for now.

@lzchen lzchen closed this Nov 16, 2020
@raphaelauv
Copy link

@lzchen why did you close ?

@lzchen
Copy link
Contributor

lzchen commented May 25, 2022

@raphaelauv

From the above comment:

I'll have a look once the spec issue is resolved, but it might make sense to just close this PR for now and post updates to the issue instead.

@raphaelauv
Copy link

can we re open it ?
it's an important feature, thanks

@lzchen
Copy link
Contributor

lzchen commented May 25, 2022

@raphaelauv

Depending on if @ffe4 would like to continue to work on this, we can reopen this pr.

@ffe4
Copy link
Contributor Author

ffe4 commented May 25, 2022

@lzchen Not sure about the details of this anymore, but I've noticed that the spec issue is still open. I can take a look over the weekend to see whether this PR might still be useful.

@ffe4 ffe4 mentioned this pull request Jun 3, 2022
Open
@ffe4
Copy link
Contributor Author

ffe4 commented Jun 3, 2022

@lzchen the structure of the codebase has changed quite a bit, so I don't think reopening this PR makes sense. I've also posted an update on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:after-ga To be resolved after GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OTEL_LOG_LEVEL env variable
4 participants
@ffe4 @lzchen @raphaelauv @codeboten