Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make return value of get_correlations immutable #1024

Merged
merged 5 commits into from
Aug 27, 2020
Merged

Make return value of get_correlations immutable #1024

merged 5 commits into from
Aug 27, 2020

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Aug 19, 2020 •
edited
Loading

Description

Makes return value of get_correlations immutable via a proxy view of a copy of the original dict.

According to the spec:

the returned value can be either an immutable collection or an immutable iterator

Fixes #1020

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ffe4 ffe4 marked this pull request as ready for review August 21, 2020 17:26
@ffe4 ffe4 requested a review from a team August 21, 2020 17:26
@codeboten codeboten merged commit 6ba985a into open-telemetry:master Aug 27, 2020
@ffe4 ffe4 deleted the issue_1020 branch September 2, 2020 21:48
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@legendecas
fix: multi span processor should flush child span processors (open-te…
2b14af3 
…lemetry#1024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

Assignees

@aabmass aabmass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_correlations return value should be immutable
4 participants
@ffe4 @aabmass @lzchen @codeboten