-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement aggregators for metrics #413
Comments
I think we need to better define the scope of this issue. The link on the description is a document that is not part of the specification yet, so I don't know if we should base the decision of what aggregators to implement to that. Currently we have |
Observer should have a "last value" aggregator. |
@MikeGoldsmith I made a typo, currently the |
@mauriciovasquezbernal - Metrics Spec just says |
In golang, the simple selector for observer basically chooses an "measure"-like aggregator. See open-telemetry/opentelemetry-go#474 (comment) So yeah, that aggregations part in metrics spec seems a bit conflicting with standard impls of instruments in metrics specs. |
@toumorokoshi @c24t |
* fix(http-plugin): move node-sdk to dev deps * refactor: rename opentelemetry-sdk-base * refactor: rename opentelemetry-tracer-basic * refactor: rename opentelemetry-node-sdk * docs: update readme * docs: update readme * refactor: rename opentelemetry-tracer-web * fix: styling * fix: doc consistency * fix: sliiped in typo * fix: postgres and doc
Currently, only the aggregator for counter metrics has been implemented.
Implement the corresponding aggregators for the rest of the metrics types.
https://github.com/open-telemetry/opentelemetry-specification/blob/2b75442b05fd968f197422dc18124338a955f3a2/specification/sdk-metric.md#aggregator-implementations
The text was updated successfully, but these errors were encountered: