-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExplicitBucketHistogram resets counts to zero even if aggregation temporality is cumulative #3407
Comments
I looked into this a bit and found the issue #3277 (comment)
|
* Fix explicit bucket histogram aggregation Fixes #3407 * Revert "Fix explicit bucket histogram aggregation" This reverts commit f1c6683. * Fix ExplicitBucketHistogramAggregation Fixes #3407 * Fix default instrument temporality * Fix last test case * Add more test cases * Test min, max and sum * Fix lint * Add CHANGELOG * Fix lint * Skip test if running in Windows
Yes, noticed that now that I added another test case. I think this is a problem for the explicit bucket histogram aggregation who is resetting to zero all bucket counts after every collection even in the aggregation temporality is cumulative. I say we review this PR and address that issue separately.
Originally posted by @aabmass in #3335 (review)
The text was updated successfully, but these errors were encountered: