Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace integration with PostgreSQL #265

Closed
hectorhdzg opened this issue Nov 4, 2019 · 6 comments
Closed

Add trace integration with PostgreSQL #265

hectorhdzg opened this issue Nov 4, 2019 · 6 comments
Assignees
Labels

Comments

@hectorhdzg
Copy link
Member

OpenCensus currently supports trace integration with Psycopg library, being one of most popular for PostgreSQL
http://initd.org/psycopg/

Other popular libraries could be also considered in the future
https://wiki.postgresql.org/wiki/Python

@hectorhdzg
Copy link
Member Author

I would like to work on this integration, please assign to me to avoid work duplication

@lzchen
Copy link
Contributor

lzchen commented Nov 4, 2019

You're going crazy with the integrations! Keep it up!

@Oberon00
Copy link
Member

Oberon00 commented Nov 7, 2019

Is there any way to write a more general integration or integration base layer based on https://www.python.org/dev/peps/pep-0249/ Python Database API Specification v2.0 "DBAPI"?

@hectorhdzg
Copy link
Member Author

@Oberon00 I have seen a couple of different DB libraries and usually follow the DBAPI in some way or another, we can have some shared code when possible, at the end we will need the specific library integration because the patching or hook if provided would be different, in the case of psycopg plenty of the code is written on C and they have a Python wrapper on top, so patching would be entirely different to other libraries, what would be a good way to share code for DB integrations?, creating another ext package like OpenCensus?

@Oberon00
Copy link
Member

Oberon00 commented Nov 8, 2019

Yes, I think something like a opentelemetry-ext-dbapi package with the shared code that the db-specific packages depend on would be the way to go -- but only if there really is code to share of course.

@toumorokoshi
Copy link
Member

Closing this as we now have dbapi and pyscopg2.

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants