Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous.callback() should not be public in the metrics API #2151

Closed
Tracked by #2140
aabmass opened this issue Sep 24, 2021 · 0 comments
Closed
Tracked by #2140

Asynchronous.callback() should not be public in the metrics API #2151

aabmass opened this issue Sep 24, 2021 · 0 comments
Assignees
@ocelotl
Labels
metrics

Comments

@aabmass
Copy link
Member

aabmass commented Sep 24, 2021 •
edited
Loading

This method should not be public

opentelemetry-python/opentelemetry-api/src/opentelemetry/metrics/instrument.py

Line 126 in ae757a9

def callback(self):

SDK instruments will need a way for the metric readers to call their callbacks, but API callbacks don't need to be called.
@aabmass aabmass mentioned this issue Sep 24, 2021
Closed
6 tasks
@ocelotl ocelotl self-assigned this Sep 29, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 29, 2021
@ocelotl
Remove checks and callbacks from API
b1435df 
Fixes open-telemetry#2151
@ocelotl ocelotl mentioned this issue Sep 29, 2021
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 30, 2021
@ocelotl
Remove checks and callbacks from API
258d4f1 
Fixes open-telemetry#2151
ocelotl added a commit that referenced this issue Oct 12, 2021
@ocelotl
Remove checks and callbacks from API (#2164)
4254a0b 
* Remove checks and callbacks from API

Fixes #2151

* Fix tests
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Oct 13, 2021
@ocelotl
Remove checks and callbacks from API (open-telemetry#2164)
450a86c 
* Remove checks and callbacks from API

Fixes open-telemetry#2151

* Fix tests
aabmass pushed a commit to aabmass/opentelemetry-python that referenced this issue Oct 29, 2021
@ocelotl @aabmass
Remove checks and callbacks from API (open-telemetry#2164)
2be0de4 
* Remove checks and callbacks from API

Fixes open-telemetry#2151

* Fix tests
@ocelotl ocelotl closed this as completed in 0aa3eb6 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aabmass @ocelotl