Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event and Link max attribute count limit use wrong env var #2042

Closed
owais opened this issue Aug 17, 2021 · 0 comments · Fixed by #2044
Closed

Event and Link max attribute count limit use wrong env var #2042

owais opened this issue Aug 17, 2021 · 0 comments · Fixed by #2044
Assignees
@owais
Labels
bug Something isn't working

Comments

@owais
Copy link
Contributor

owais commented Aug 17, 2021

Describe your environment
Event and link attribute count limits use the wrong environment variables in SpanLimits. https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py#L575-L584

What is the expected behavior?
OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT and OTEL_LINK_ATTRIBUTE_COUNT_LIMIT should be used to configure these limits.

What is the actual behavior?
OTEL_SPAN_LINK_COUNT_LIMIT is wrongly used to configure both.
@owais owais added the bug Something isn't working label Aug 17, 2021
@owais owais self-assigned this Aug 17, 2021
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Add support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
ce1ca9d 
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
@owais owais mentioned this issue Aug 17, 2021
Merged
12 tasks
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Add support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
9de1931 
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
ac3d758 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
b5732eb 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
b8c6ce2 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
6f25751 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
5c8ef2e 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
14d3e46 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 17, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
061e72c 
Fixes open-telemetry#2045
Fixes open-telemetry#2043
Fixes open-telemetry#2042
Fixes open-telemetry#2041
owais added a commit that referenced this issue Aug 19, 2021
@owais
Added support for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT (#2044)
2a726e4 
Fixes #2045
Fixes #2043
Fixes #2042
Fixes #2041
owais added a commit that referenced this issue Aug 24, 2021
@owais @lzchen
Fix limit env vars unset/unlimited values (#2054)
b5704d5 
* Added support for `OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT`

Fixes #2045
Fixes #2043
Fixes #2042
Fixes #2041

* SpanLimit: Treat empty value env vars as unset

Fixes #2052

* Update CHANGELOG.md

Co-authored-by: Leighton Chen <lechen@microsoft.com>

Co-authored-by: Leighton Chen <lechen@microsoft.com>
owais added a commit that referenced this issue Aug 24, 2021
@owais
Add support for OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT env var (#2056)
4250078 
* Added support for `OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT`

Fixes #2045
Fixes #2043
Fixes #2042
Fixes #2041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owais owais

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for additional Span Limits owais/opentelemetry-python
1 participant
@owais