Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Config file support for instrumentor and other components #1035

Closed
owais opened this issue Aug 23, 2020 · 2 comments
Closed

Proposal: Config file support for instrumentor and other components #1035

owais opened this issue Aug 23, 2020 · 2 comments

Comments

@owais
Copy link
Contributor

owais commented Aug 23, 2020

There was some discussion to about ways to configure auto-instrumentation in #663. There was also some debate about env vars vs a config file. I don't think OpenTelemetry Python should dictate users use either env vars or a config file. I think both should be supported for end users. At the same time components shouldn't have to deal with os.environ, files or multiple config APIs. I'm proposing a fairly simple solution that allows us to have both without changing the existing config API in any way: https://docs.google.com/document/d/1SpNhP19QiaAxptDMriyIdKWtsRNXzAmPRtjl0EX14H8

This is certainly not a requirement for any feature but I think we should consider it iff we were to add support for config files.

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@owais
Copy link
Contributor Author

owais commented Sep 14, 2021

This is irrelevant now. Was proposed a long time ago and never discussed in detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants