bugfix: indent not used in MetricsData to_json (#3197)

open-telemetry · Feb 24, 2023 · a9a96aa · a9a96aa
1 parent 69de3dc
commit a9a96aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 - PeriodicExportingMetricReader will continue if collection times out 
   ([#3100](https://github.com/open-telemetry/opentelemetry-python/pull/3100))
-
+- Fix formatting of ConsoleMetricExporter.
+  ([#3197](https://github.com/open-telemetry/opentelemetry-python/pull/3197))
 
 ## Version 1.16.0/0.37b0 (2023-02-17)
 - Change ``__all__`` to be statically defined.

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py
@@ -211,5 +211,6 @@ def to_json(self, indent=4) -> str:
                     loads(resource_metrics.to_json(indent=indent))
                     for resource_metrics in self.resource_metrics
                 ]
-            }
+            },
+            indent=indent,
         )
diff --git a/opentelemetry-sdk/tests/metrics/integration_test/test_console_exporter.py b/opentelemetry-sdk/tests/metrics/integration_test/test_console_exporter.py
@@ -49,7 +49,7 @@ def test_console_exporter(self):
         provider.shutdown()
 
         output.seek(0)
-        result_0 = loads(output.readlines()[0])
+        result_0 = loads("".join(output.readlines()))
 
         self.assertGreater(len(result_0), 0)