fix except handling in get_aggregated_resources

Avoids UnboundLocalError: local variable 'detected_resource' referenced before assignment if raise_on_error is True
open-telemetry · Feb 17, 2022 · 76b000d · 76b000d
1 parent ec3053e
commit 76b000d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
@@ -309,11 +309,11 @@ def get_aggregated_resources(
             # pylint: disable=broad-except
             except Exception as ex:
                 if detector.raise_on_error:
+                    detected_resource = _EMPTY_RESOURCE
                     raise ex
                 logger.warning(
                     "Exception %s in detector %s, ignoring", ex, detector
                 )
-                detected_resource = _EMPTY_RESOURCE
             finally:
                 detectors_merged_resource = detectors_merged_resource.merge(
                     detected_resource