Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap gen #757

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Update bootstrap gen #757

merged 2 commits into from
Oct 19, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Oct 19, 2021

Description

Global generate check was removed from CI workflow and a specific check was added to generate bootstrap script in this commit:
d2984f5#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88L112-L114
d2984f5#diff-0b911e478cf36c1398ccb7c6b5a371bc2fb5b7a962f897ae28acd3027fe1cecdR109-R120

However, it prevented the checks to actually run for code generation scripts other than genertate_instrumentation_bootstrap.py. At this point we had generate check only working for generate_instrumentation_bootstrap.py in CI.

Next change was migration of opentelemetry-instrumentation to contrib which included removal of the bootstap specific check here: 7cf3cb4#diff-0b911e478cf36c1398ccb7c6b5a371bc2fb5b7a962f897ae28acd3027fe1cecdL109-L120

Since that commit, we haven't had generate checks run in CI for any script.

This PR adds the generate checks back.

As a direct result of this, our latest release is somewhat broken. Installing opentelemetry-instrumentation==0.25b1 install a bootstrap command which forces a downgrade to 0.25b0 of all instrumentation packages.

Effect

Check is working as expected now:
image

Type of change

Please delete options that are not relevant.

  • Dev/tooling enhancement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team October 19, 2021 07:37
@owais owais force-pushed the update-bootstrap-gen branch from 95f0d91 to 305d15e Compare October 19, 2021 07:46
@owais owais force-pushed the update-bootstrap-gen branch from 305d15e to ef9ad2b Compare October 19, 2021 07:54
@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 19, 2021
@owais owais enabled auto-merge (squash) October 19, 2021 16:28
@owais owais merged commit 27e58e5 into open-telemetry:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants