Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Global generate check was removed from CI workflow and a specific check was added to generate bootstrap script in this commit:
d2984f5#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88L112-L114
d2984f5#diff-0b911e478cf36c1398ccb7c6b5a371bc2fb5b7a962f897ae28acd3027fe1cecdR109-R120
However, it prevented the checks to actually run for code generation scripts other than genertate_instrumentation_bootstrap.py. At this point we had generate check only working for generate_instrumentation_bootstrap.py in CI.
Next change was migration of opentelemetry-instrumentation to contrib which included removal of the bootstap specific check here: 7cf3cb4#diff-0b911e478cf36c1398ccb7c6b5a371bc2fb5b7a962f897ae28acd3027fe1cecdL109-L120
Since that commit, we haven't had generate checks run in CI for any script.
This PR adds the generate checks back.
As a direct result of this, our latest release is somewhat broken. Installing
opentelemetry-instrumentation==0.25b1
install a bootstrap command which forces a downgrade to0.25b0
of all instrumentation packages.Effect
Check is working as expected now:
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.