httpx: update type hints to RequestInfo/ResponseInfo
#3105
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
changed the title
RequestInfo/ResponseInfoRequestInfo/ResponseInfo
emdneto
reviewed
Dec 16, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Show resolved
Hide resolved
emdneto
reviewed
Dec 16, 2024
emdneto
approved these changes
Dec 16, 2024
emdneto
reviewed
Dec 17, 2024
CHANGELOG.md
Outdated
| @@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - `opentelemetry-instrumentation-httpx` Update `RequestInfo`/`ResponseInfo` type hints | |||
There was a problem hiding this comment.
Suggested change
| - `opentelemetry-instrumentation-httpx` Update `RequestInfo`/`ResponseInfo` type hints | |
| ### Fixed | |
| - `opentelemetry-instrumentation-httpx` Fix `RequestInfo`/`ResponseInfo` type hints |
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
lzchen
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is type related, it's specific to the issue above.
I've also created #3098 to add more type hints to this module. I'm happy to rebase there in case this gets accepted.