Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.7.0 #3100

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

rjduffner
Copy link
Contributor

@rjduffner rjduffner commented Dec 12, 2024

Description

Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.7.0

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran standard existing tests through tox

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

@rjduffner rjduffner force-pushed the rd-support-confluent-kafka-261 branch from adbb83f to c6e43e7 Compare December 13, 2024 15:59
@rjduffner rjduffner marked this pull request as ready for review December 13, 2024 16:27
@rjduffner rjduffner requested a review from a team as a code owner December 13, 2024 16:27
@rjduffner rjduffner force-pushed the rd-support-confluent-kafka-261 branch from 0f5a6e2 to 932d815 Compare December 16, 2024 20:25
@rjduffner
Copy link
Contributor Author

@xrmx, sorry to bother you, is there an @ available to get the owners of this instrumentation to look?

Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
@emdneto
Copy link
Member

emdneto commented Dec 16, 2024

@xrmx, sorry to bother you, is there an @ available to get the owners of this instrumentation to look?

Thank you!

At this moment, I don't think we have someone looking at it. We welcome any contributor which has knowledge on the instrumentation to also help on reviews, so feel free to add yourself to componentes_owners.yml

@rjduffner
Copy link
Contributor Author

Thanks @emdneto and @lzchen!

@lzchen lzchen merged commit 52ff7bd into open-telemetry:main Dec 17, 2024
573 checks passed
@ashwinxbhc
Copy link

@rjduffner - When will the stable version from dev for 51b be released, because we have already upgraded out confluent kafka versions to 2.6.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants