OpenAI - update semantic conventions to the latest version, write logs based events instead of span events #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Oct 26, 2024
instrumentation/opentelemetry-instrumentation-openai-v2/tests/conftest.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Oct 28, 2024
xrmx
reviewed
Oct 28, 2024
instrumentation/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Oct 28, 2024
instrumentation/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Show resolved
Hide resolved
lzchen
reviewed
Oct 28, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Show resolved
Hide resolved
lmolkova
changed the title
lzchen
reviewed
Oct 29, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
openai-update-semconv-to-latest
branch
from
9baa3d7 to
70eed99
Compare
karthikscale3
approved these changes
Oct 30, 2024
|
looking good, thanks for doing this @lmolkova |
alizenhom
approved these changes
Oct 30, 2024
xrmx
reviewed
Oct 30, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Oct 30, 2024
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
…entelemetry/instrumentation/openai_v2/utils.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…pen-telemetry#2909) httpx: rewrote patching to use wrapt instead of subclassing client Porting of httpx instrumentation to patch async transport methods instead of substituting the client. That is because the current approach will instrument httpx by instantianting another client with a custom transport class and this will race with code already subclassing. This one uses wrapt to patch the default httpx transport classes. --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODOs:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.