opentelemetry-instrumentation: make it easier to use bootstrap with custom values #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
reviewed
Oct 22, 2024
…ustom values Pass the available instrumentation libraries and the default libraries from bootstrap_gen to run() (and down to all the functions) instead of relying on the globals. This way it's easier to reuse run with custom values. While at it fix mock handling in tests.
xrmx
force-pushed
the
enhances-bootstrap
branch
from
fd7b3d5
to
c25890d
Compare
pmcollins
approved these changes
Oct 24, 2024
emdneto
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the available instrumentation libraries and the default libraries from bootstrap_gen to run() (and down to all the functions) instead of relying on the globals. This way it's easier to reuse run() with custom values.
While at it fix mock handling in tests.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.