-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grpc supported version #2845
Conversation
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given you are the first to report I think we don't have many users with older grpc then
@xrmx can you help add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add the changelog and also change the code in instrumentation/opentelemetry-instrumentation-grpc/package.py
to match documentation and then run python scripts/generate_instrumentation_bootstrap.py
to regenerate bootstrap_gen.py
$ python3 scripts/generate_instrumentation_bootstrap.py
>>> black --config github/opentelemetry-python-contrib/pyproject.toml .
reformatted github/opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
All done! ✨ 🍰 ✨
1 file reformatted, 12 files left unchanged.
>>> isort --settings-path github/opentelemetry-python-contrib/.isort.cfg --profile black .
INFO:instrumentation_list_generator:generatedgithub/opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py There seems to be no changes in |
Yeah to the list of things to update I forgot the package |
thx, done~ |
@JaredTan95 Please add the changelog and we are good I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also at the end run tox -e generate
Description
Our python application uses
grpcio==1.34.0
(greater than version1.27
as described in the documentation)The
opentelemetry-instrumentation-grpc 1.27.0
plugin conflicts withgrpcio==1.34.0
, resulting in the following error:This has been fixed for grpc in version
1.42.0
3 years ago: grpc/grpc@9699580