fix for Audit and test opentelemetry-instrumentation-jinja2 #978 #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metry#978 Signed-off-by: Ramshankar, B <b.ramshankar@fmr.com>
ramshankarb
force-pushed
the
fix-issue-978
branch
from
393eac9 to
a3f4ea6
Compare
lzchen
approved these changes
Aug 14, 2024
emdneto
approved these changes
Aug 14, 2024
|
@ramshankarb care to fix lint? |
|
@emdneto Sure, PR will be updated soon with linting. |
zhihali
approved these changes
Aug 16, 2024
instrumentation/opentelemetry-instrumentation-jinja2/tests/test_jinja2.py
Outdated
Show resolved
Hide resolved
Signed-off-by: B Ramshankar <b.ramshankar@fmr.com>
|
Looks like you got some extra blank space. |
fixed linting Signed-off-by: B Ramshankar <b.ramshankar@fmr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds NoOpTracerProvider test cases for jinja2 instrumentation.
Fixes #978
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.