Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-bootstrap: remove aws-lambda from default instrumentations #2786

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `opentelemetry-instrumentation-kafka-python` Instrument temporary fork, kafka-python-ng
inside kafka-python's instrumentation
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537)))
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537))

## Breaking changes

- `opentelemetry-bootstrap` Remove `opentelemetry-instrumentation-aws-lambda` from the defaults instrumentations
([#2786](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2786))

## Fixed

- `opentelemetry-instrumentation-aws-lambda` Avoid exception when a handler is not present.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@
]
default_instrumentations = [
"opentelemetry-instrumentation-asyncio==0.48b0.dev",
"opentelemetry-instrumentation-aws-lambda==0.48b0.dev",
"opentelemetry-instrumentation-dbapi==0.48b0.dev",
"opentelemetry-instrumentation-logging==0.48b0.dev",
"opentelemetry-instrumentation-sqlite3==0.48b0.dev",
Expand Down
4 changes: 4 additions & 0 deletions scripts/generate_instrumentation_bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,16 @@
"bootstrap_gen.py",
)

packages_to_ignore = ["opentelemetry-instrumentation-aws-lambda"]
emdneto marked this conversation as resolved.
Show resolved Hide resolved


def main():
# pylint: disable=no-member
default_instrumentations = ast.List(elts=[])
libraries = ast.List(elts=[])
for pkg in get_instrumentation_packages():
if pkg.get("name") in packages_to_ignore:
continue
if not pkg["instruments"]:
default_instrumentations.elts.append(ast.Str(pkg["requirement"]))
for target_pkg in pkg["instruments"]:
Expand Down