Ensure httpx non-client methods are instrumented #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
May 21, 2024
instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py
Show resolved
Hide resolved
|
If you want to share credits you can add a |
xrmx
reviewed
May 21, 2024
xrmx
approved these changes
May 21, 2024
It was a great idea until I tried to implement it by looking at the previous MR (+ .patch) for the author's e-mail, except that it's a hidden github e-mail which doesn't have the CLA signed. 🤣 Let's just leave it as is, I hope I'll be forgiven. 😅 |
ocelotl
reviewed
May 22, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Show resolved
Hide resolved
ocelotl
previously approved these changes
May 22, 2024
ocelotl
reviewed
May 22, 2024
Merged
10 tasks
6 tasks
ocelotl
approved these changes
May 30, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update of previous MR for which the original author unfortunately didn't submit the updates required for merging into
main. We actively use this instrumentation and this instrumentation gap is quite annoying to deal with.Quote from MR
The
httpx.get,httpx.post, etc. methods ultimately usehttpx._api.request, which makes instantiateshttpx._api.Client. Buthttpx.Clientis modified during instrumentation without updating the value imported in thehttpx._apimodule.Fixing this was as easy as also patching the
Clientvalue inhttpx._api.All credit for the fix goes to @dmontagu.
Fixes #1742
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
httpxwithouthttpx.Client. Uninstrumentation is also tested.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.