-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confluent kafka producer poll and flush returns #2527
Merged
lzchen
merged 9 commits into
open-telemetry:main
from
dferrochio:add_confluent_kafka_producer_returns
May 30, 2024
Merged
Add confluent kafka producer poll and flush returns #2527
lzchen
merged 9 commits into
open-telemetry:main
from
dferrochio:add_confluent_kafka_producer_returns
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dferrochio You need to sign the CLA |
@xrmx CLA signed |
xrmx
approved these changes
May 18, 2024
@oxeye-dorkolog can review?, please |
ocelotl
approved these changes
May 22, 2024
lzchen
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add return statement to Confluent kafka Producer poll() and flush() calls when instrumented by ConfluentKafkaInstrumentor().instrument_producer()
Fixes #2525
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unittests for instrumented Confluent kafka producer poll and flush methods.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.