Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed urllib3 instrumentation example in instrumentation documentation #1793

Merged
merged 8 commits into from
Jun 16, 2023
Merged

Fixed urllib3 instrumentation example in instrumentation documentation #1793

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45581df
corrected instrumentation example in urllib3
yashaswi2000 May 10, 2023
09c9e03
Merge branch 'main' into first-contrib-opentelemetry
shalevr May 16, 2023
1c58909
Merge branch 'main' into first-contrib-opentelemetry
shalevr May 17, 2023
388806f
Merge branch 'main' into first-contrib-opentelemetry
shalevr May 23, 2023
6a1e546
Merge branch 'main' into first-contrib-opentelemetry
shalevr May 24, 2023
62a6f5e
Merge branch 'main' into first-contrib-opentelemetry
ocelotl Jun 13, 2023
52a00d5
Remove changelog entry
ocelotl Jun 13, 2023
0a6d04a
Merge branch 'main' into first-contrib-opentelemetry
shalevr Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed urllib3 instrumentation example in instrumentation documentation
ocelotl marked this conversation as resolved.
Show resolved Hide resolved
([#1793](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1793))
- Fix elasticsearch db.statement attribute to be sanitized by default
([#1758](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1758))
- Fix `AttributeError` when AWS Lambda handler receives a list event
Expand Down
4 changes: 2 additions & 2 deletions instrumentation/opentelemetry-instrumentation-urllib3/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ The hooks can be configured as follows:
def response_hook(span, request, response):
pass

URLLib3Instrumentor.instrument(
request_hook=request_hook, response_hook=response_hook)
URLLib3Instrumentor().instrument(
request_hook=request_hook, response_hook=response_hook
)

Exclude lists
Expand Down
4 changes: 2 additions & 2 deletions ...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def request_hook(span, request):
def response_hook(span, request, response):
pass

URLLib3Instrumentor.instrument(
request_hook=request_hook, response_hook=response_hook)
URLLib3Instrumentor().instrument(
request_hook=request_hook, response_hook=response_hook
)

Exclude lists
Expand Down