Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TortoiseORM instrumentation] Fix AttributeError: type object 'Config' has no attribute 'title' #1575

Merged
merged 11 commits into from
Feb 6, 2023
Merged

[TortoiseORM instrumentation] Fix AttributeError: type object 'Config' has no attribute 'title' #1575

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c34b011
Use pydantic model name as default `title` value
fullonic Jan 12, 2023
e29b7dd
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Jan 13, 2023
a4b2ced
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Jan 16, 2023
7ddeda5
Update `CHANGELOG.md`
fullonic Jan 16, 2023
35edc65
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Jan 19, 2023
22644f9
Format with black
fullonic Jan 19, 2023
381fc9e
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Jan 19, 2023
3e69487
Lint with `black`
fullonic Jan 19, 2023
ed7d01f
Merge branch 'fix/add-default-value-if-title-doesnt-exists' of https:…
fullonic Jan 19, 2023
d920844
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Jan 23, 2023
38c2241
Merge branch 'main' into fix/add-default-value-if-title-doesnt-exists
fullonic Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...try-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ async def _from_queryset(self, func, modelcls, args, kwargs):

model_config = getattr(modelcls, "Config", None)
if model_config:
model_title = getattr(modelcls.Config, "title")
model_title = getattr(modelcls.Config, "title", modelcls.__name__)
if model_title:
span_attributes["pydantic.model"] = model_title

Expand Down