-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for anonymous tasks #1407
Merged
srikanthccv
merged 18 commits into
open-telemetry:main
from
naormalca:celery_add_support_for_anon_tasks_fix
Apr 28, 2023
Merged
Add support for anonymous tasks #1407
srikanthccv
merged 18 commits into
open-telemetry:main
from
naormalca:celery_add_support_for_anon_tasks_fix
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naormalca
changed the title
[WIP]Celery add support for anon tasks
Celery add support for anon tasks
Oct 26, 2022
naormalca
changed the title
Celery add support for anon tasks
[WIP]Celery add support for anon tasks
Oct 28, 2022
The last time I tried running the change, it didn't fix the issue. Is it still the case? |
the change is fixing the issue, it tested with a unit test and integration tests on my project. what scenario reproduced the issue for you? |
naormalca
changed the title
[WIP]Celery add support for anon tasks
Celery add support for anon tasks
Oct 29, 2022
naormalca
changed the title
Celery add support for anon tasks
Celery add support for anonymous tasks
Oct 29, 2022
srikanthccv
reviewed
Nov 6, 2022
...on/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py
Show resolved
Hide resolved
10 tasks
naormalca
changed the title
Celery add support for anonymous tasks
[WIP]Celery add support for anonymous tasks
Jan 2, 2023
srikanthccv
reviewed
Feb 4, 2023
srikanthccv
changed the title
[WIP]Celery add support for anonymous tasks
Add support for anonymous tasks
Apr 28, 2023
srikanthccv
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work that goatsthatcode did on #1052, due to the fact that the author hasn't responded anymore, we are interested in resolving this issue.
This changes the way spans are initialized for the celery instrumentation hooks and handles the case where Celery tasks are not available in the registry and called anonymously using the signature() or send_task()
Fixes #1002, #609
possibly addresses #784
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.