Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for anonymous tasks #1407

Merged

Conversation

naormalca
Copy link
Contributor

@naormalca naormalca commented Oct 26, 2022

Description

This PR continues the work that goatsthatcode did on #1052, due to the fact that the author hasn't responded anymore, we are interested in resolving this issue.

This changes the way spans are initialized for the celery instrumentation hooks and handles the case where Celery tasks are not available in the registry and called anonymously using the signature() or send_task()

Fixes #1002, #609
possibly addresses #784

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@naormalca naormalca requested a review from a team October 26, 2022 06:41
@naormalca naormalca changed the title [WIP]Celery add support for anon tasks Celery add support for anon tasks Oct 26, 2022
@aabmass aabmass assigned aabmass and unassigned aabmass Oct 26, 2022
@naormalca naormalca changed the title Celery add support for anon tasks [WIP]Celery add support for anon tasks Oct 28, 2022
@srikanthccv
Copy link
Member

The last time I tried running the change, it didn't fix the issue. Is it still the case?

@naormalca
Copy link
Contributor Author

The last time I tried running the change, it didn't fix the issue. Is it still the case?

the change is fixing the issue, it tested with a unit test and integration tests on my project. what scenario reproduced the issue for you?

@naormalca naormalca changed the title [WIP]Celery add support for anon tasks Celery add support for anon tasks Oct 29, 2022
@naormalca naormalca changed the title Celery add support for anon tasks Celery add support for anonymous tasks Oct 29, 2022
@srikanthccv srikanthccv mentioned this pull request Dec 10, 2022
10 tasks
@naormalca naormalca changed the title Celery add support for anonymous tasks [WIP]Celery add support for anonymous tasks Jan 2, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@srikanthccv srikanthccv changed the title [WIP]Celery add support for anonymous tasks Add support for anonymous tasks Apr 28, 2023
@srikanthccv srikanthccv enabled auto-merge (squash) April 28, 2023 22:33
@srikanthccv srikanthccv merged commit 46e4b1d into open-telemetry:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using CeleryInstrumentor and linking Celery task trace back to requested trace
5 participants