-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement initial pulsar support #1405
base: main
Are you sure you want to change the base?
feat: Implement initial pulsar support #1405
Conversation
3d3b1f3
to
d63243c
Compare
...ation/opentelemetry-instrumentation-pulsar/src/opentelemetry/instrumentation/pulsar/utils.py
Show resolved
Hide resolved
) | ||
|
||
span.set_attribute( | ||
SpanAttributes.MESSAGING_KAFKA_PARTITION, message.partition() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpanAttributes.MESSAGING_KAFKA_PARTITION, message.partition() | |
SpanAttributes.MESSAGING_PULSAR_PARTITION, message.partition() |
...on/opentelemetry-instrumentation-pulsar/src/opentelemetry/instrumentation/pulsar/__init__.py
Outdated
Show resolved
Hide resolved
...on/opentelemetry-instrumentation-pulsar/src/opentelemetry/instrumentation/pulsar/__init__.py
Outdated
Show resolved
Hide resolved
...ation/opentelemetry-instrumentation-pulsar/src/opentelemetry/instrumentation/pulsar/utils.py
Show resolved
Hide resolved
...ion/opentelemetry-instrumentation-pulsar/src/opentelemetry/instrumentation/pulsar/version.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please take a look at the comments.
2bdb46a
to
1eb2a31
Compare
Done, I just rebased it with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments only
Hi @ocelotl i sent the fixes again, the broken tests seem unrelated to my changes, they break on http* libray |
@ocelotl I notice a bug in |
63f37e8
to
d451397
Compare
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
…elemetry/instrumentation/pulsar/__init__.py Co-authored-by: Rani Mufid <ranimufid@gmail.com>
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
…api compatibility Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
…r better visibility in jaeger and zipkin Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
Signed-off-by: Jayson Reis <santosdosreis@gmail.com>
d451397
to
239f307
Compare
The `trace.use_span(span, True)` will already close this span, if we store this same span in the message, it'll be closed by a call to any of the `*acknowledge` functions, essentially causing a double call to `span.end()`. This change prevents this from happening by not storing the span in the message.
Fix: double end call
|
Description
This adds an initial support for pulsar
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Initial integration tests were run with the following:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.