Add support for regular expression matching and sanitizing of headers in WSGI. #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srikanthccv Here's the WSGI PR! |
rogersd
force-pushed
the
drogers-wildcard-headers-wsgi
branch
2 times, most recently
from
34e50c4 to
1dd0a9f
Compare
rogersd
force-pushed
the
drogers-wildcard-headers-wsgi
branch
from
1dd0a9f to
4288f13
Compare
rogersd
commented
Oct 24, 2022
| @@ -16,10 +16,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#1369](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1369)) | |||
| - `opentelemetry-instrumentation-system-metrics` add supports to collect system thread count. ([#1339](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1339)) | |||
| - `opentelemetry-exporter-richconsole` Fixing RichConsoleExpoter to allow multiple traces, fixing duplicate spans and include resources ([#1336](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1336)) | |||
| - `opentelemetry-instrumentation-asgi` Add support for regular expression matching of HTTP headers. | |||
| - `opentelemetry-instrumentation-asgi` Add support for regular expression matching and sanitization of HTTP headers. | |||
There was a problem hiding this comment.
Whoops, I should have mentioned the sanitization on this one too.
srikanthccv
approved these changes
Oct 26, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next part of #1184
Description
Add test cases for regular expression matching.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.
Fixes #1184
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.