Fix exception in Urllib3 when dealing with filelike body.

[isra17]

Description

Only use len on body if it's not a filelike object.

Fixex #1235

How Has This Been Tested?

tox -e test-instrumentation-urllib3

[ocelotl]

Please resolve conflicts

[isra17]

Done

[srikanthccv]

Please fix the conflicts

[isra17]

Done again.

[isra17]

Seems like the test broke since the first commit. Pushed a fixed version.

[gtmanfred]

@shalevr @srikanthccv any chance this could be merged? it is preventing us from migrating from opentracing to opentelemetry.

[srikanthccv]

It can't be merged unless all the requirements are met. The author didn't let maintainers make edits, which prevents me from updating (out-of-date with base) and merging it.

[isra17]

It can't be merged unless all the requirements are met. The author didn't let maintainers make edits, which prevents me from updating (out-of-date with base) and merging it.

I can't give edit access to the PR since the fork is being owned by an org and not a personnal account. Let me rebase again and fix conflict. If there's conflict again in the future I would suggest you just cherry-pick my commit and open your own pull request. I understand maintaining open-source software is thankless work (And I thank you for otel!), but this PR have many times the amount of work it actually required due to at least 5 rebase with conflict that appears each time right before merging.

[isra17]

My rebase conflicted with a7bd563 which did a similar thing than my PR (moved all the test to test_urllib3_metrcs.py, but changed the test to use HttpTestBase while my PR worked on this comment #1399 (comment) and pretty much rewrite the whole test suite. I kept my rewrite instead of the master version, however I can't use the HTTP server since it only support GET request with a specific payload while my tests requires more use-cases.

[isra17]

Ok, finally fixed the test with the new base utils assert_.... Should be green now!

[srikanthccv]

It can't be merged unless all the requirements are met. The author didn't let maintainers make edits, which prevents me from updating (out-of-date with base) and merging it.

I can't give edit access to the PR since the fork is being owned by an org and not a personnal account. Let me rebase again and fix conflict. If there's conflict again in the future I would suggest you just cherry-pick my commit and open your own pull request. I understand maintaining open-source software is thankless work (And I thank you for otel!), but this PR have many times the amount of work it actually required due to at least 5 rebase with conflict that appears each time right before merging.

I wouldn't mind somebody else creating the PR for the same fix, getting that merged, and then closing this. You may have n number of reasons not to give edit access, even if it wasn't an org account. I mentioned that because the last time I wanted to merge this two weeks ago, this was not up to date with the base branch. Many PRs in this repo let the maintainer make edits (for such cases) and merge quickly. I also enabled the auto-merge, but that didn't help either. I can't hold other PRs ready to merge because this needs rebasing etc...

[shalevr]

LGTM, thank you

[gtmanfred]

Thank you very much all of yall! we really appreciate it.