Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-system-metrics restore package #1012

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Mar 18, 2022

Description

Restore the system-metrics instrumentation package into main from the metrics branch and update its usage of the api/sdk. Leaving in draft until the tests are fixed

Fix #1011

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Alex Boten added 4 commits April 4, 2022 11:07
Restore the system-metrics instrumentation package into main from the `metrics` branch and update its usage of the api/sdk.

Fix open-telemetry#1011
@codeboten codeboten force-pushed the codeboten/restore-system-metrics branch from f751396 to f105899 Compare April 4, 2022 18:10
@codeboten codeboten marked this pull request as ready for review April 4, 2022 18:12
@codeboten codeboten requested a review from a team April 4, 2022 18:12
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the configuration mechanism in this instrumentation is largely superseded by views. Wdyt @codeboten?

Approving since most of this code is being restored. Thanks for undertaking this Alex!

Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue to track the work needed to support pypy3: #1033

CHANGELOG.md Outdated Show resolved Hide resolved
@lzchen lzchen merged commit 40c1805 into open-telemetry:main Apr 6, 2022
@codeboten codeboten deleted the codeboten/restore-system-metrics branch April 6, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore instrumentation/system-metrics
4 participants