-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
falcon
: Remove or fix Python 3.4+ support
#772
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
This is a mistake. The project only supports Python 3.6+. We should update all pacakges to reflect that. |
owais
added
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Oct 24, 2021
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this issue
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
6 tasks
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this issue
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
owais
pushed a commit
that referenced
this issue
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes #772.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
The
falcon
instrumentation is the only one marked with support for Python versions other than>=3.6
, allowing Python 3.4+.However, since #693, f-strings were introduced to this repository, which should be breaking applications that want to use this instrumentation along with Python 3.4 (not tested).
Even more, considering that
opentelemetry-sdk
andopentelemetry-api
are also marked withpython_requires = >=3.6
, it seems it's no longer possible to install thefalcon
installation on Python 3.4 anymore.Example Dockerfile:
Build logs:
The text was updated successfully, but these errors were encountered: