fix: lint and bump version

open-telemetry · Nov 27, 2020 · 2cbd7ba · 2cbd7ba
1 parent 6df5238
commit 2cbd7ba
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 15 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-urllib/CHANGELOG.md b/instrumentation/opentelemetry-instrumentation-urllib/CHANGELOG.md
@@ -1,7 +1,7 @@
 # Changelog
 
-## Version 0.15b0
+## Version 0.16b1
 
-Released 2020-11-26
+Released 2020-11-27
 
 - Initial release
diff --git a/instrumentation/opentelemetry-instrumentation-urllib/README.rst b/instrumentation/opentelemetry-instrumentation-urllib/README.rst
@@ -7,7 +7,7 @@ OpenTelemetry urllib Instrumentation
    :target: https://pypi.org/project/opentelemetry-instrumentation-urllib/
 
 This library allows tracing HTTP requests made by the
-`urllib https://docs.python.org/3/library/urllib.html>`_ library.
+`urllib <https://docs.python.org/3/library/urllib.html>`_ library.
 
 Installation
 ------------

diff --git a/instrumentation/opentelemetry-instrumentation-urllib/setup.cfg b/instrumentation/opentelemetry-instrumentation-urllib/setup.cfg
@@ -39,8 +39,8 @@ package_dir=
     =src
 packages=find_namespace:
 install_requires =
-    opentelemetry-api == 0.15b0
-    opentelemetry-instrumentation == 0.15b0
+    opentelemetry-api == 0.16b1
+    opentelemetry-instrumentation == 0.16b1
 
 [options.extras_require]
 test =

diff --git a/...opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py b/...opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py
@@ -52,11 +52,7 @@
 from opentelemetry.instrumentation.urllib.version import __version__
 from opentelemetry.instrumentation.utils import http_status_to_status_code
 from opentelemetry.trace import SpanKind, get_tracer
-from opentelemetry.trace.status import (
-    EXCEPTION_STATUS_FIELD,
-    Status,
-    StatusCode,
-)
+from opentelemetry.trace.status import Status, StatusCode
 
 # A key to a context variable to avoid creating duplicate spans when instrumenting
 _SUPPRESS_URLLIB_INSTRUMENTATION_KEY = "suppress_urllib_instrumentation"
@@ -139,11 +135,7 @@ def _instrumented_requests_call(
                     result = call_wrapped()  # *** PROCEED
                 except Exception as exc:  # pylint: disable=W0703
                     exception = exc
-                    setattr(
-                        exception, EXCEPTION_STATUS_FIELD, StatusCode.ERROR,
-                    )
                     result = getattr(exc, "file", None)
-                    # TODO GER RESPONSE
                 finally:
                     context.detach(token)
 

diff --git a/.../opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/version.py b/.../opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/version.py
@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-__version__ = "0.15b0"
+__version__ = "0.16b1"