Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed Node and ProcessIdentifier #80

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 12 additions & 132 deletions gen/go/agent/common/v1/common.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions opentelemetry/proto/agent/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ This package describes the OpenTelemetry Agent protocol.

## Packages

1. `common` package contains the common messages shared between different services, such as
`Node`, `Service` and `Library` identifiers.
1. `common` package contains the common messages shared between different services.
2. `trace` package contains the Trace Service protos.
3. `metrics` package contains the Metrics Service protos.
3. `metrics` package contains the Metrics Service protos.
25 changes: 0 additions & 25 deletions opentelemetry/proto/agent/common/v1/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,3 @@ option java_multiple_files = true;
option java_package = "io.opentelemetry.proto.agent.common.v1";
option java_outer_classname = "CommonProto";
option go_package = "github.com/open-telemetry/opentelemetry-proto/gen/go/agent/common/v1";

// Identifier metadata of the Node that produces the span or tracing data.
// Note, this is not the metadata about the Node or service that is described by associated spans.
// In the future we plan to extend the identifier proto definition to support
// additional information (e.g cloud id, etc.)
message Node {
// Identifier that uniquely identifies a process within a VM/container.
ProcessIdentifier identifier = 1;

// Additional attributes.
map<string, string> attributes = 4;

// TODO(songya): Add more identifiers in the future as needed, like cloud
// identifiers.
}

// Identifier that uniquely identifies a process within a VM/container.
message ProcessIdentifier {

// Process id.
uint32 pid = 2;

// Start time of this ProcessIdentifier. Represented in epoch time.
google.protobuf.Timestamp start_timestamp = 3;
}