Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: drop BuildIdKind #584

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

florianl
Copy link
Contributor

Drop BuildIdKind in favor of its semantic convention as defined in open-telemetry/semantic-conventions#1329.

FYI: @open-telemetry/profiling-maintainers
spec:profiles

Drop `BuildIdKind` in favor of its semantic convention as defined in open-telemetry/semantic-conventions#1329.
@florianl florianl requested review from a team September 10, 2024 13:48
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx 🙇

florianl added a commit to open-telemetry/opentelemetry-ebpf-profiler that referenced this pull request Sep 12, 2024
open-telemetry/semantic-conventions#1329 got
merged, which introduces a semantic convention for build_ids. Use this
semantic convention in favor of BuildIdKind, that will be dropped with
open-telemetry/opentelemetry-proto#584.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl added a commit to open-telemetry/opentelemetry-ebpf-profiler that referenced this pull request Sep 12, 2024
open-telemetry/semantic-conventions#1329 got
merged, which introduces a semantic convention for build_ids. Use this
semantic convention in favor of BuildIdKind, that will be dropped with
open-telemetry/opentelemetry-proto#584.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@tigrannajaryan tigrannajaryan merged commit 4f69356 into open-telemetry:main Sep 16, 2024
15 checks passed
dmathieu pushed a commit to dmathieu/opentelemetry-proto that referenced this pull request Sep 23, 2024
Drop `BuildIdKind` in favor of its semantic convention as defined in open-telemetry/semantic-conventions#1329.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants