Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: add missing java_package option to pprofextended. #558

Merged
merged 1 commit into from
May 13, 2024

Conversation

jhalliday
Copy link
Contributor

Gah, we put java_package on one file but not the other. Oops.
Apparently the opentelementry-proto-java artifact can't be consumed by opentelemetry-java without this.

@jhalliday jhalliday requested review from a team May 10, 2024 10:44
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is blocking java from upgrading to the latest protos.

@tigrannajaryan tigrannajaryan merged commit a05597b into open-telemetry:main May 13, 2024
16 checks passed
@jack-berg
Copy link
Member

Is there a plan to cut a release with this change?

@tigrannajaryan
Copy link
Member

Is there a plan to cut a release with this change?

@jack-berg feel free to cut a patch release. Instructions: https://github.com/open-telemetry/opentelemetry-proto/blob/main/RELEASING.md

Let me know if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants