Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the incorrect histogram example in metrics.json #510

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix the incorrect histogram example in metrics.json #510

merged 3 commits into from
Nov 9, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Oct 27, 2023

There are 2 buckets (-inf, 1), [1, +inf) but 3 bucket counts.

@songy23
Fix the incorrect histogram example in metrics.json
af0a28e 
There are 2 buckets (-inf, 1), [1, +inf) but 3 bucket counts.
@songy23 songy23 requested a review from a team October 27, 2023 15:23
jack-berg
jack-berg reviewed Oct 27, 2023
View reviewed changes
examples/metrics.json Outdated Show resolved Hide resolved
@tigrannajaryan
Copy link
Member

@open-telemetry/specs-metrics-approvers please review.

songy23
songy23 commented Nov 7, 2023
View reviewed changes
Copy link
Member Author

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews, this should be good to go

@tigrannajaryan tigrannajaryan merged commit ea449ae into open-telemetry:main Nov 9, 2023
14 checks passed
@songy23 songy23 deleted the patch-1 branch November 9, 2023 19:52
@MrAlias MrAlias mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@songy23 @tigrannajaryan @cijothomas @MrAlias @jack-berg @arminru