Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an optional zero_threshold field to ExponentialHistogramDataPoint #441

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Jan 3, 2023

Introduce an optional zero_threshold field to ExponentialHistogramDataPoint.
See Zero Count and Zero Threshold.

Resolves #440

@kovrus kovrus marked this pull request as ready for review January 3, 2023 15:43
@kovrus kovrus requested review from a team January 3, 2023 15:43
@kovrus
Copy link
Member Author

kovrus commented Jan 3, 2023

cc: @gouthamve @jmacd

@kovrus kovrus requested a review from Aneurysm9 January 4, 2023 17:14
@kovrus kovrus requested review from gouthamve and Aneurysm9 and removed request for Aneurysm9 and gouthamve January 5, 2023 11:02
@kovrus
Copy link
Member Author

kovrus commented Jan 10, 2023

cc: @dashpole

@kovrus kovrus requested review from jmacd and removed request for gouthamve January 10, 2023 16:43
@kovrus
Copy link
Member Author

kovrus commented Jan 23, 2023

Hey @open-telemetry/specs-approvers, can you merge that, please?

@reyang
Copy link
Member

reyang commented Jan 23, 2023

Hey @open-telemetry/specs-approvers, can you merge that, please?

Please get more folks to review the PR.

@kovrus
Copy link
Member Author

kovrus commented Jan 23, 2023

@reyang any suggestions on whom should I ask to review this PR?

@reyang
Copy link
Member

reyang commented Jan 23, 2023

@reyang any suggestions on whom should I ask to review this PR?

@open-telemetry/specs-metrics-approvers @dashpole @gouthamve @pirgeo

@reyang reyang merged commit ad7b716 into open-telemetry:main Jan 23, 2023
@kovrus kovrus deleted the issue-440 branch January 24, 2023 08:21
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional zero_threshold to ExponentialHistogramDataPoint.
8 participants