Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading comments for Span in trace.proto #408

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Remove misleading comments for Span in trace.proto #408

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ba558
Clarify "multiple root spans"
arminru Jun 22, 2022
6ec85a6
Remove most of the description for Span
arminru Jun 27, 2022
5df1686
Merge branch 'main' into multiple-root-spans
arminru Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions opentelemetry/proto/trace/v1/trace.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ message InstrumentationLibrarySpans {
// nested to form a trace tree. Spans may also be linked to other spans
// from the same or different trace and form graphs. Often, a trace
// contains a root span that describes the end-to-end latency, and one
// or more subspans for its sub-operations. A trace can also contain
// multiple root spans, or none at all. Spans do not need to be
// or more subspans for its sub-operations. Technically a trace could also
// contain multiple root spans, or none at all, but the semantics of
// these cases are not defined. Spans do not need to be
// contiguous - there may be gaps or overlaps between spans in a trace.
//
// The next available field id is 17.
Expand Down